-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Start from snapshot for drone push projection #1044
Conversation
.snapshotWhen { (_, event, _) => | ||
event.isInstanceOf[CoarseGrainedLocationChanged] | ||
} | ||
// #startFromSnapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag for every coarse grained so we always have such a starting point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, don't care about history and just use the latest makes sense for this
samples/grpc/local-drone-control-scala/src/main/scala/local/drones/DroneEvents.scala
Outdated
Show resolved
Hide resolved
I added eventsBySlicesStartingFromSnapshots in the other place. |
eventProducer.eventProducerSource.entityType, | ||
0, | ||
maxSlice), | ||
// FIXME EventProducerSettings.EventProducerSource.startingFromSnapshots not used and no public accessor to pick it up from there, confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled this fixme in #1049
Need this in the java sample too, I can add that after lunch. |
42898ac
to
11dee03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for finishing it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Depends on #1047 and event writer fix P is working on over in Akka
Depends on #1048